Skip to content

[CMake] Add preset for building executor_runner with profiling #12682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2025
Merged

[CMake] Add preset for building executor_runner with profiling #12682

merged 4 commits into from
Jul 30, 2025

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Jul 21, 2025 •
edited
Loading

Adding a new preset for users to build executor_runner for profiling. I will follow up later with a script on generating a .csv for the models per-operator profiling information

cmake --preset profiling
cmake --build cmake-out/ --target executor_runner

@mcr229
Update
69c472b 
[ghstack-poisoned]
@mcr229
Copy link
Contributor Author

mcr229 commented Jul 21, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12682

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit cf93425 with merge base 2c84f70 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
mcr229 added a commit that referenced this pull request Jul 21, 2025
@mcr229
[CMake] Add preset for building executor_runner with profiling
9ac709c 
ghstack-source-id: c74d859
ghstack-comment-id: 3097983009
Pull Request resolved: #12682
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@larryliu0820
Copy link
Contributor

Have you tried to compose it with target preset? Like

cmake --preset profiling --preset macos

@swolchok
Copy link
Contributor

please make sure to add this to build-presets.yml so CI stops it from getting broken

@mcr229
Update
41c23c8 
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Jul 22, 2025
@mcr229
[CMake] Add preset for building executor_runner with profiling
f9796ea 
ghstack-source-id: 00bb8f1
ghstack-comment-id: 3097983009
Pull Request resolved: #12682
@mcr229
Update
8d7171d 
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Jul 29, 2025
@mcr229
[CMake] Add preset for building executor_runner with profiling
4945efd 
ghstack-source-id: 0282861
ghstack-comment-id: 3097983009
Pull Request resolved: #12682
@mcr229
Update
cf93425 
[ghstack-poisoned]
mcr229 added a commit that referenced this pull request Jul 29, 2025
@mcr229
[CMake] Add preset for building executor_runner with profiling
2be4c30 
ghstack-source-id: f232190
ghstack-comment-id: 3097983009
Pull Request resolved: #12682
@mcr229 mcr229 merged commit bdf658b into main Jul 30, 2025
101 of 102 checks passed
@mcr229 mcr229 deleted the gh/mcr229/42/head branch July 30, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin

@mergennachin mergennachin Awaiting requested review from mergennachin

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcr229 @larryliu0820 @swolchok @kirklandsign